| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR. |
Sorry, something went wrong.
|
Result: ⚠️ partially-verified Verification detailsVerification: Isolated verification observed failures that were not classified as caused by this PR: Wrapper idempotence and startup-global smoke checks. Summary: On Python 3.13.16, the targeted shell-integration file reported **11 passed**, including the PR’s new prompt-conversion test. Additional checks confirmed idempotent wrapping, single prompt conversions, and Python 3.11 compatibility. An actual-PS1 smoke check failed because this environment runs under WSL, where pythonrc deliberately suppresses sys.ps1; existing prompt-rendering tests also return early there. Verification is partial, with no observed PR-caused failure. Test runs: 3 passed, 1 failed
calls = [] class Prompt: with patch.object(interact, 'multiline_input', original): with patch.object(interact, 'multiline_input', original):
print('Python:', sys.version.split()[0]) PASS: reload keeps wrapper identity; both prompts converted exactly once; arguments/result preserved Ctrl click to launch VS Code Native REPL (https://aka.ms/python-native-repl) Traceback (most recent call last): File "<stdin>", line 42, in <module> AttributeError: module 'sys' has no attribute 'ps1' [container exit=1] The subsequent compatibility check confirmed WSL, where pythonrc's existing installation condition suppresses sys.ps1. |
Sorry, something went wrong.
There was a problem hiding this comment.
Approved via Review Center.
Sorry, something went wrong.
There was a problem hiding this comment.
The reviewed changes include regression coverage and no unresolved issues were identified.
Review effort: Lite
Findings: None
Updates PyREPL integration to convert ps1 and ps2 prompts to strings before multiline input handling.
Changes:
| File | Description |
|---|---|
| python_files/tests/test_shell_integration.py | Tests prompt conversion behavior. |
| python_files/pythonrc.py | Adds the PyREPL prompt-conversion wrapper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Fixes #25467
Improve the integration of prompt handling in the REPL, ensuring that prompts are always passed as strings to _pyrepl.simple_interact.multiline_input
This makes sure that PS1 is converted to string even in python versions without the fix (e.g., 3.15.0r2 - 3.15.0)
Testing