Fix all typescript errors when compiled in strict mode #2 - #4411
Merged
Kartik Raj (karrtikr) merged 5 commits intoFeb 15, 2019
Merged
Fix all typescript errors when compiled in strict mode #2#4411Kartik Raj (karrtikr) merged 5 commits into
Kartik Raj (karrtikr) merged 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Don Jayamanne (DonJayamanne)
requested changes
Feb 14, 2019
Comment thread
src/client/unittests/common/services/unitTestDiagnosticService.ts
Outdated
Comment thread
src/client/unittests/common/services/unitTestDiagnosticService.ts
Outdated
Comment thread
src/client/unittests/types.ts
Comment thread
src/client/unittests/types.ts
Outdated
Kartik Raj (karrtikr)
force-pushed
the
errors2
branch
from
8694df6 to
93e9503
Compare
February 14, 2019 23:52
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #4411 +/- ##
========================================
+ Coverage 57% 78% +21%
========================================
Files 364 439 +75
Lines 15495 20525 +5030
Branches 2408 3291 +883
========================================
+ Hits 8752 15816 +7064
+ Misses 6163 4705 -1458
+ Partials 580 4 -576
|
Sorry, something went wrong.
Don Jayamanne (DonJayamanne)
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #611 part 2