Fix all typescript errors when compiled in strict mode #3 - #4419
Merged
Derek Keeler (d3r3kk) merged 7 commits intoMar 1, 2019
Merged
Fix all typescript errors when compiled in strict mode #3#4419Derek Keeler (d3r3kk) merged 7 commits into
Derek Keeler (d3r3kk) merged 7 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #4419 +/- ##
========================================
+ Coverage 58% 78% +20%
========================================
Files 369 445 +76
Lines 15946 21071 +5125
Branches 2507 3423 +916
========================================
+ Hits 9134 16241 +7107
+ Misses 6190 4824 -1366
+ Partials 622 6 -616
|
Sorry, something went wrong.
Kartik Raj (karrtikr)
force-pushed
the
errors3
branch
from
64126f2 to
2047e9f
Compare
February 15, 2019 22:09
Derek Keeler (d3r3kk)
approved these changes
Feb 28, 2019
Derek Keeler (d3r3kk)
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
I think this should be fine, it's not changing any of the logic from the original versions. However, the use of null instead of undefined seems suspect. Please have a quick chat with Don Jayamanne (@DonJayamanne) on the places where I make mention of this before merging.
Sorry, something went wrong.
Comment thread
src/client/unittests/display/main.ts
Comment thread
src/client/unittests/pytest/services/testMessageService.ts
Outdated
Comment thread
src/client/unittests/pytest/services/testMessageService.ts
added 2 commits
February 28, 2019 12:15
Kartik Raj (karrtikr)
force-pushed
the
errors3
branch
from
de73f86 to
71bc1ca
Compare
February 28, 2019 20:25
added 2 commits
February 28, 2019 12:29
Comment thread
src/test/debugger/misc.test.ts
Outdated
Co-Authored-By: karrtikr <karraj@microsoft.com>
Copy link
Copy Markdown
|
CI timeout/matplotlib problem (should be fixed now). |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #611 part 3