FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix problem with other kernels that use python being picked. by rchiodo · Pull Request #5628 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Fix problem with other kernels that use python being picked. - #5628

Merged
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/fix_5586
May 14, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Fix problem with other kernels that use python being picked.#5628
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/fix_5586

Conversation

Rich Chiodo (rchiodo) commented May 14, 2019

Copy link
Copy Markdown

For #5586

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Rich Chiodo (rchiodo) commented May 14, 2019

Copy link
Copy Markdown
Author

I also added support for debugging in a devcontainer.

Ian Huff (IanMatthewHuff) approved these changes May 14, 2019
View reviewed changes

Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rich Chiodo (rchiodo) merged commit f1deef6 into master May 14, 2019
Rich Chiodo (rchiodo) deleted the rchiodo/fix_5586 branch May 14, 2019 20:15
lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL