FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix overwriting of cwd in test discovery path list by kimadeline · Pull Request #6713 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Fix overwriting of cwd in test discovery path list - #6713

Merged
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
kimadeline:6417-test-discovery-adapter-path
Jul 29, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Fix overwriting of cwd in test discovery path list#6713
Don Jayamanne (DonJayamanne) merged 2 commits into
microsoft:masterfrom
kimadeline:6417-test-discovery-adapter-path

Conversation

Kim-Adeline Miguel (kimadeline) commented Jul 26, 2019

Copy link
Copy Markdown

For #6417

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • [n/a] Appropriate comments and documentation strings in the code
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [n/a] The wiki is updated with any design decisions/details.

Eric Snow (ericsnowcurrently) approved these changes Jul 29, 2019
View reviewed changes

Eric Snow (ericsnowcurrently) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Don Jayamanne (DonJayamanne) merged commit cac8024 into microsoft:master Jul 29, 2019
Kim-Adeline Miguel (kimadeline) deleted the 6417-test-discovery-adapter-path branch July 30, 2019 06:11
lock Bot locked as resolved and limited conversation to collaborators Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
Eric Snow (ericsnowcurrently) ericsnowcurrently approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL