Debug Mode Code lenses - #6792
Merged
Ian Huff (IanMatthewHuff) merged 14 commits intoJul 31, 2019
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Ian Huff (IanMatthewHuff)
requested review from
David Kutugata (DavidKutu),
Joyce Er (joyceerhl) and
Rich Chiodo (rchiodo)
July 31, 2019 15:44
Comment thread
src/client/datascience/debugLocationTracker.ts
Outdated
| private getStackTrace(message: any): IDebugLocation | undefined { | ||
| if (message.command === 'stackTrace') { | ||
| if (message.body.stackFrames.length > 0) { | ||
| const lineNumber = message.body.stackFrames[0].line; |
Copy link
Copy Markdown
There was a problem hiding this comment.
stackFrames [](start = 48, length = 11)
I believe there is a DebugProtocol set of types. I used them in some of the MockDebuggerService. Might make this easier to verify #Resolved
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Ahh, there totally is. I wasn't liking how loose the any stuff was. I'll use 'em
In reply to: 309303086 [](ancestors = 309303086)
Sorry, something went wrong.
Comment thread
src/test/datascience/mockDebugService.ts
Outdated
| throw new Error('Method not implemented.'); | ||
| } | ||
| public registerDebugAdapterTrackerFactory(_debugType: string, _provider: DebugAdapterTrackerFactory): Disposable { | ||
| throw new Error('Method not implemented.'); |
Copy link
Copy Markdown
There was a problem hiding this comment.
Error [](start = 18, length = 5)
I think if you implemented this, we could have a functional test for this stuff. #Resolved
Sorry, something went wrong.
Rich Chiodo (rchiodo)
approved these changes
Jul 31, 2019
Rich Chiodo (rchiodo)
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Sorry, something went wrong.
Ian Huff (IanMatthewHuff)
added a commit
to IanMatthewHuff/vscode-python
that referenced
this pull request
Jul 31, 2019
Ian Huff (IanMatthewHuff)
added a commit
that referenced
this pull request
Aug 1, 2019
Debug Mode Code lenses (#6792)
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Aug 6, 2019
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Aug 7, 2019
* Make dataviewers open faster (#6795) * Fix experiments hash parsing (#6492) * Simplify & fix crypto.createHash * Add tests * Fix python test in news folder (#6398) * Fix broken python tests in news * Revert changes * Release cherry pick (#6515) * Enable experiment for always displaying the test explorer (#6330) * Add logging * Point release - Updated package.json and CHANGELOG (#6516) * Cherry pick change from master * Fix npm audit * Make dataviewers open faster * Fix package-lock.json * Debug Mode Code lenses (#6792) * Cherry-pick miniconda fix into rc * August Release (#6868) * Exclude .env file from extension (#6872) * Update from master * Update package lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #6672