FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow the language server to choose its default caching mode by jakebailey · Pull Request #7822 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Allow the language server to choose its default caching mode - #7822

Merged
Karthik Nadig (karthiknadig) merged 1 commit into
microsoft:masterfrom
jakebailey:default-caching
Oct 8, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Allow the language server to choose its default caching mode#7822
Karthik Nadig (karthiknadig) merged 1 commit into
microsoft:masterfrom
jakebailey:default-caching

Conversation

Jake Bailey (jakebailey) commented Oct 8, 2019

Copy link
Copy Markdown
Member

For #7821

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

Codecov (codecov-io) commented Oct 8, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7822 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7822   +/-   ##
=======================================
  Coverage   59.25%   59.25%           
=======================================
  Files         498      498           
  Lines       22293    22293           
  Branches     3580     3580           
=======================================
  Hits        13209    13209           
  Misses       8262     8262           
  Partials      822      822

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c5607...13df376. Read the comment docs.

Karthik Nadig (karthiknadig) merged commit 5e9eaaf into microsoft:master Oct 8, 2019
Jake Bailey (jakebailey) deleted the default-caching branch October 8, 2019 19:26
Karthik Nadig (karthiknadig) pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 8, 2019
Allow the language server to choose its default caching mode (microso…
c7130f8 
…ft#7822)
Karthik Nadig (karthiknadig) added a commit that referenced this pull request Oct 8, 2019
Preparing for release (#7828)
48fe766 
* Allow the language server to choose its default caching mode (#7822)
* Preparing for release
* Update to change logs
* Grammar and typo fixes.
lock Bot locked as resolved and limited conversation to collaborators Oct 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Karthik Nadig (karthiknadig) karthiknadig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL