When starting Jupyter activate conda env - #9972
Merged
Don Jayamanne (DonJayamanne) merged 2 commits intoFeb 7, 2020
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Don Jayamanne (DonJayamanne)
requested review from
David Kutugata (DavidKutu),
Ian Huff (IanMatthewHuff) and
Rich Chiodo (rchiodo)
February 6, 2020 23:51
Rich Chiodo (rchiodo)
approved these changes
Feb 6, 2020
Copy link
Copy Markdown
Author
|
Does this CI even work... |
Sorry, something went wrong.
David Kutugata (DavidKutu)
approved these changes
Feb 6, 2020
Ian Huff (IanMatthewHuff)
approved these changes
Feb 7, 2020
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #9972 +/- ##
=========================================
- Coverage 61.2% 61.2% -0.01%
=========================================
Files 564 564
Lines 30078 30083 +5
Branches 4550 4551 +1
=========================================
+ Hits 18408 18411 +3
- Misses 10640 10642 +2
Partials 1030 1030
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Kudos, SonarCloud Quality Gate passed!
|
Sorry, something went wrong.
Don Jayamanne (DonJayamanne)
added a commit
that referenced
this pull request
Feb 7, 2020
* If interpreter is provided use that to check if is conda environment * Fix tests For #9973 Currently conda isn't getting activated when auto starting Jupyter server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9973
Currently conda isn't getting activated when auto starting Jupyter server.