FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Porting K8 fix to release by IanMatthewHuff · Pull Request #9987 · microsoft/vscode-python · GitHub

/ vscode-python Public
forked from DonJayamanne/pythonVSCode

Porting K8 fix to release - #9987

Merged
Ian Huff (IanMatthewHuff) merged 2 commits into
microsoft:release-2020.02from
IanMatthewHuff:dev/ianhu/portK8Fix
Feb 7, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Porting K8 fix to release#9987
Ian Huff (IanMatthewHuff) merged 2 commits into
microsoft:release-2020.02from
IanMatthewHuff:dev/ianhu/portK8Fix

Conversation

Ian Huff (IanMatthewHuff) commented Feb 7, 2020

Copy link
Copy Markdown
Member

For #9976

Porting this PR:
#9977

To release branch for next week's release.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

Codecov (codecov-io) commented Feb 7, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9987 into release-2020.02 will not change coverage.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           release-2020.02   #9987   +/-   ##
===============================================
  Coverage             61.2%   61.2%           
===============================================
  Files                  564     564           
  Lines                30083   30083           
  Branches              4551    4551           
===============================================
  Hits                 18411   18411           
  Misses               10642   10642           
  Partials              1030    1030
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 67.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4946e5c...36958f7. Read the comment docs.

Ian Huff (IanMatthewHuff) added the no-changelog No news entry required label Feb 7, 2020

Ian Huff (IanMatthewHuff) commented Feb 7, 2020

Copy link
Copy Markdown
Member Author

npm ci fails in CI

sonarqubecloud Bot commented Feb 7, 2020

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

Ian Huff (IanMatthewHuff) merged commit 3be03b0 into microsoft:release-2020.02 Feb 7, 2020
Ian Huff (IanMatthewHuff) deleted the dev/ianhu/portK8Fix branch February 7, 2020 21:59
lock Bot locked as resolved and limited conversation to collaborators Feb 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Rich Chiodo (rchiodo) rchiodo approved these changes
Don Jayamanne (DonJayamanne) Awaiting requested review from DonJayamanne
+1 more reviewer
David Kutugata (DavidKutu) DavidKutu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL