settings: adding autoStartBrowserURL setting to customize the URL tha… - #581
settings: adding autoStartBrowserURL setting to customize the URL tha…#581Max Schmit (maxschmi) wants to merge 1 commit into
Conversation
Sorry, something went wrong.
…t is opened when the browser starts
|
@microsoft-github-policy-service agree company="University of Freiburg" |
Sorry, something went wrong.
| if (debugConfiguration.autoStartBrowser && (debugConfiguration.django || isFlask)) { | ||
| let pattern = '.*(?:(http|https):\\/\\/\\S+:[0-9]+\\/?).*'; | ||
| if (debugConfiguration.autoStartBrowserURL !== undefined) { | ||
| pattern = `.*(${debugConfiguration.autoStartBrowserURL}).*`; |
There was a problem hiding this comment.
what is the reasoning behind having the .* appended here instead of just having the user submit the exact string match they want in the setting? This feels like it might confuse people if they manual configure with the starting * on their own
Sorry, something went wrong.
|
apologies for the delay- I added a comment with a quick question and have also began some discussions with my team around the addition of a config option. Thanks! |
Sorry, something went wrong.
|
Hello, My Idea was to use your regular expression pattern searching implementation that is already there. As there were the point in front and after the searching group I kept those. I guess they are there because the pattern looks for complete lines. So in the end you can simply enter the URL as hard coded string and it will work or you can enter your own regular expression pattern. But I see your point that this might be confusing and probably unnessecary. |
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
fixes #580
Added autoStartBrowserURL setting to customize the URL that is started on Browser Startup