Fix environment variable substitution in .env files - #766
Open
Govert (gverkes) wants to merge 1 commit into
Open
Fix environment variable substitution in .env files#766Govert (gverkes) wants to merge 1 commit into
Govert (gverkes) wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- Merge process.env with debugLaunchEnvVars before parsing .env file
- This ensures system environment variables like PATH are available for substitution
- Add comprehensive unit tests for environment variable substitution
- Fixes issue where ${PATH} and other system vars weren't expanded in .env files
Copy link
Copy Markdown
Author
|
@microsoft-github-policy-service agree company="CuspAI" |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159
Summary
Fixed environment variable substitution in .env files by ensuring system environment variables are available during parsing.
Problem
When using environment variable substitution in .env files (e.g., PATH="${PATH};custom-path"), system environment variables were not available for substitution. Only the launch configuration's env variables were passed to the parser.
Solution
Modified helper.ts to merge process.env with debugLaunchEnvVars before passing to the env file parser. This ensures all system environment variables are available for substitution while still allowing launch config variables to override system ones.
Test plan