Pull request overview

Adds unit-level “headless conformance” coverage to ensure package manager operations (Pip/Conda/Poetry) do not prompt for interactive input or display error UI when runHeadless: true, while still rejecting on failures. Also aligns Pip’s UI entry points with the existing VS Code wrapper APIs so they can be controlled/stubbed consistently in tests.

Changes:

• Added a shared unit test suite that exercises headless package-management behavior across Pip, Conda, and Poetry.
• Updated PipPackageManager to use withProgress / showErrorMessage from common/window.apis instead of vscode.window directly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

src/managers/builtin/pipPackageManager.ts:82

• New/updated user-facing strings in this hunk (progress titles like "Installing packages" and the error UI text/button) are not localized. The repo consistently localizes UI strings via l10n.t(...) or centralized string modules (e.g., CondaStrings from src/common/localize.ts). Please localize these strings so they’re translatable.

        await withProgress(
            {
                location: ProgressLocation.Notification,
                title: 'Installing packages',
                cancellable: true,
            },

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

.github/workflows/pr-check.yml:337

• The workflow no longer sets VSC_PYTHON_PACKAGE_NETWORK_TEST=1, so src/test/integration/packageManager.integration.test.ts will now always this.skip() (see line ~108) and the package-manager network integration suite won’t run in CI at all. If these tests are still intended to protect behavior, reintroduce a gated step that sets the env var (or remove/adjust the env guard and run them via an explicit job).

        if: runner.os == 'Linux'
        uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d # v1.6
        with:
          run: npm run integration-test

      - name: Run Integration Tests (non-Linux)
        if: runner.os != 'Linux'
        run: npm run integration-test

.github/workflows/push-check.yml:336

• The workflow no longer sets VSC_PYTHON_PACKAGE_NETWORK_TEST=1, so src/test/integration/packageManager.integration.test.ts will now always this.skip() (see line ~108) and the package-manager network integration suite won’t run on pushes either. If the suite is still required, add back a gated step that exports the env var (or migrate the tests away from env gating).

      - name: Run Integration Tests (Linux)
        if: runner.os == 'Linux'
        uses: GabrielBB/xvfb-action@86d97bde4a65fe9b290c0b3fb92c2c4ed0e5302d # v1.6
        with:
          run: npm run integration-test

      - name: Run Integration Tests (non-Linux)
        if: runner.os != 'Linux'

Approved via Review Center.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

src/test/integration/environmentFixture.ts:379

• If process-tree termination rejects, or if the force timer fires before close, this promise settles while the original child may still be running. Fixture setup then enters dispose() and can start provider/root deletion against that active process. Keep the fixture in a pending-cleanup state until child exit is confirmed (similar to the API-removal guard) instead of allowing direct cleanup after an unconfirmed kill.

            void terminateProcessTree(child).catch((error) => {
                finish(new Error(`${timeoutError.message}\nFailed to terminate process tree: ${toError(error).message}`));
            });
            forceTimer = setTimeout(() => finish(timeoutError), 10_000);

src/test/managers/builtin/pipPackageManager.unit.test.ts:133

• This fixture still hardcodes a POSIX absolute path. On Windows, Uri.file('/path/to/environment') produces a drive-relative path, so the unit test no longer exercises the same path shape as production. Build the URI from __dirname, as the shared conformance fixture does.

            environmentPath: Uri.file('/path/to/environment'),

No approval-blocking issues found. The headless package operations suppress progress/error UI while preserving operational failures, and the integration cleanup uses randomized ownership markers plus strict path-containment checks before destructive removal. I also confirmed that both PR and push CI enable the network lifecycle coverage.

Non-blocking follow-up: additional focused cleanup tests for ownership mismatch, out-of-root prefixes, partial setup, and removal timeout would strengthen the fixture coverage.

Written by an AI agent on behalf of Eleanor.

Approved via Review Center.