FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Detect Frameworks after smart mode ready by ghostflyby · Pull Request #2630 · minecraft-dev/MinecraftDev · GitHub

/ MinecraftDev Public

Detect Frameworks after smart mode ready - #2630

Open
ghostflyby wants to merge 5 commits into
minecraft-dev:devfrom
ghostflyby:detection-index
ConversationCommits (5)ChecksFiles changed
Open

Detect Frameworks after smart mode ready#2630
ghostflyby wants to merge 5 commits into
minecraft-dev:devfrom
ghostflyby:detection-index

Conversation

ghostflyby commented Jul 16, 2026

Copy link
Copy Markdown

A performance improvement.

Use cases of LibraryPresentationProvider by the IDE itself only matches the jar name by regex, proving that they are not intended for file iterations.

Framework kind are useless when the index is not ready.

All tests passed.

closes #2475

DenWav commented Aug 5, 2026

Copy link
Copy Markdown
Member

In concept I like this change, but it is a lot. There's several merges here, can you rebase your branch to get a clean set of commits in this PR?

ghostflyby force-pushed the detection-index branch 2 times, most recently from c78554b to 908db7a Compare August 5, 2026 05:53

DenWav commented Aug 5, 2026

Copy link
Copy Markdown
Member

Much nicer, thanks.

DenWav requested changes Aug 9, 2026
View reviewed changes

DenWav left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm concerned about handling of CancellationException, but I haven't looked deeply enough into this PR yet, will do so when I get the time.

Comment thread src/main/kotlin/platform/adventure/framework/AdventureLibraryDetector.kt

class AdventurePresentationProvider : LibraryPresentationProvider<DummyLibraryProperties>(ADVENTURE_LIBRARY_KIND) {
override fun getIcon(properties: DummyLibraryProperties?) = PlatformAssets.ADVENTURE_ICON
class AdventureLibraryDetector : MinecraftLibraryDetector {

DenWav Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All of these classes were renamed to *LibraryDetector, but the file name is still *PresentationProvider. The file name should match in this case.

Comment thread src/main/kotlin/facet/MinecraftLibraryDetector.kt
import com.intellij.psi.JavaPsiFacade
import com.intellij.psi.search.FilenameIndex
import com.intellij.psi.search.GlobalSearchScope
import java.util.*

DenWav Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No wildcard imports please.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DenWav DenWav requested changes

Assignees

No one assigned

Labels

type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix frequent “Detecting Minecraft frameworks” with heavy system load.

2 participants

Back | FazBrowse Home | New Git URL