GetObject: fix adding additional headers - #192
Merged
harshavardhana merged 1 commit intoFeb 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
balamurugana
requested changes
Feb 11, 2025
Comment thread
src/baseclient.cc
balamurugana
approved these changes
Feb 11, 2025
harshavardhana
approved these changes
Feb 11, 2025
Copy link
Copy Markdown
Contributor
Author
|
@harshavardhana @balamurugana Could you please release a new package on Conan center? Many thanks. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the BaseClient::GetObject(GetObjectArgs args) API does not consume the ObjectConditionalReadArgs::Headers() method. This results in conditional headers such as Range or If-Unmodified-Since not being included in the HTTP request. This PR fixes this issue.