FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Minor nits by fsschneider · Pull Request #832 · mlcommons/algorithmic-efficiency · GitHub

/ algorithmic-efficiency Public

Minor nits - #832

Merged
priyakasimbeg merged 4 commits into
mlcommons:devfrom
fsschneider:minor_nits
Feb 10, 2025
ConversationCommits (4)ChecksFiles changed
Merged

Minor nits#832
priyakasimbeg merged 4 commits into
mlcommons:devfrom
fsschneider:minor_nits

Conversation

fsschneider commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

Depends on #830 and #831

  • Rename a job in regression_tests_variants. There were two jobs called criteo_resnet_pytorch I believe the latter one should actually be called criteo_embed_init_pytorch.
  • Minor nits to formatting in markdown files (to be consistent with what markdownlint suggests).

fsschneider requested a review from a team as a code owner January 15, 2025 15:15

github-actions Bot commented Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

fsschneider mentioned this pull request Jan 15, 2025
Merged
fsschneider mentioned this pull request Feb 3, 2025
Merged

priyakasimbeg commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

The regression test for variants are in an incomplete state. I think we should probably add all the other workloads to the test or remove the entire test.
Since we will not be using the variants for scoring, we may not need to maintain (and test them). Although if we don't maintain them, we should probably just remove them. Wdyt Frank?

fsschneider commented Feb 6, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, I agree. We probably don't want to maintain them and should thus remove them from the code.
We could double-check this decision in a quick working group decision. And then in a follow-up PR, we could remove the held-out workloads from our codebase.

priyakasimbeg merged commit b356844 into mlcommons:dev Feb 10, 2025
github-actions Bot locked and limited conversation to collaborators Feb 10, 2025
fsschneider deleted the minor_nits branch June 18, 2025 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

priyakasimbeg priyakasimbeg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL