Migrate JAX workloads from pmap to jit - #848
Merged
priyakasimbeg merged 147 commits intoAug 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Apply it to the MNIST workload and the Nesterov optimizer.
Still need to test out (a) output losses, (b) speed, and (c) look into other librispeech.
compilation caching really speeds things up when doing repeated runs.
Copy link
Copy Markdown
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
We didn't migrate all the optimizers. Should we look into migrating the following?
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
The above algorithms are buggy and we have no plans to fix them, so instead of maintaining them we should delete them |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The goal of this PR is to allow model parameter and optimizer state sharding, and also to migrate the JAX code from using jax.pmap to using jax.jit.
TODOs:
Changelog