FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Switch from yapf/pylint/isort to ruff by fsschneider · Pull Request #874 · mlcommons/algorithmic-efficiency · GitHub

/ algorithmic-efficiency Public

Switch from yapf/pylint/isort to ruff - #874

Merged
priyakasimbeg merged 28 commits into
mlcommons:devfrom
fsschneider:ruff
Jun 26, 2025
ConversationCommits (28)ChecksFiles changed
Merged

Switch from yapf/pylint/isort to ruff#874
priyakasimbeg merged 28 commits into
mlcommons:devfrom
fsschneider:ruff

Conversation

fsschneider commented Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR updates our codebase to use ruff for linting and formatting, replacing yapf, pylint, and isort. ruff offers the combined functionality of all three tools while being significantly faster.

Previously, running yapf, pylint, and isort locally took ~1m 16s on my workstation.

pylint algoperf && pylint reference_algorithms && pylint prize_qualification_baselines && pylint submission_runner.py && pylint tests && isort . --check --diff && yapf . --diff --recursive

In contrast, running ruff took ~0.14s on my workstation.

ruff check && ruff format --check

In GitHub Actions, the improvement is less dramatic due to tool installation times, but I observed roughly a 50% reduction in runtime.

Steps

  • Use ruff in GitHub Actions.
  • Update documentation to use ruff.
  • Ensure that the entire codebase conforms to the new ruff code style.

github-actions Bot commented Jun 18, 2025 •
edited
Loading

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

fsschneider self-assigned this Jun 18, 2025
fsschneider marked this pull request as ready for review June 23, 2025 11:30
fsschneider requested a review from a team as a code owner June 23, 2025 11:30

priyakasimbeg commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@fsschneider, sorry, there are some merge conflicts after I merged in the dropout refactoring. Could you help resolve the merge conflicts please? I think we just want to accept incoming changes from the dev branch and then reformat them with ruff.

fsschneider added 24 commits June 25, 2025 11:33
Formatting, ignore .eggs/ in yapf
78a1409
Replace yapf, pylint, isort with ruff
462e8b7
Replace pre-commit with ruff
383db7a
Use extend-select instead, and reduce lint rules
2c28136
Replace linting GH actions with ruff
999f7a2
Add ruff badge
7b245d6
Update style testing with ruff
277674c
Format submission_runner
830d2c2
Format submissions/
d84eddf
Format scoring/
fbbeafa
Format reference_algorithms/
f4ae9be
Format tests/
e5209d1
Format prize_qualification_baselines/
f026711
Format datasets/
531c99e
Format algoperf/
c34af17
Format docker/
9725554
Lint tests/
7b18fff
Lint submissions/
f34bb6d
Remove perf. profile tests as it is only a placeholder
0aeb545
Lint scoring/
4802dfb
Lint prize_qualification_baselines/
5e97e78
Lint datasets/
4ae5418
Lint reference_algorithms/
e3f1b74
Lint algoperf/
566b6d9

fsschneider commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

@fsschneider, sorry, there are some merge conflicts after I merged in the dropout refactoring. Could you help resolve the merge conflicts please? I think we just want to accept incoming changes from the dev branch and then reformat them with ruff.

I believe I resolved them now.
Do we have any tests for the dropout refactoring? This would ensure that I didn't break anything.

fsschneider mentioned this pull request Jun 25, 2025
Merged
12 tasks

priyakasimbeg commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

LGTM!

priyakasimbeg merged commit f2b4feb into mlcommons:dev Jun 26, 2025
github-actions Bot locked and limited conversation to collaborators Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

priyakasimbeg priyakasimbeg approved these changes

Assignees

fsschneider

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL