Dropout Fix - Final Polishing: updated submissions, tests, docs. - #884
Merged
priyakasimbeg merged 9 commits intoAug 26, 2025
Merged
Dropout Fix - Final Polishing: updated submissions, tests, docs.#884priyakasimbeg merged 9 commits into
priyakasimbeg merged 9 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Sorry, something went wrong.
priyakasimbeg
approved these changes
Aug 26, 2025
priyakasimbeg
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM! Thank you for tying up the loose ends Niccolo!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new dropout design in AlgoPerf (see #753 (comment) and #873) requires passing dropout_rate to the workload’s forward pass function rather than to init_model_fn. Some minor issues from this change were left unresolved, and this PR fixes them.