FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

use host_processors_per_node in final report by guschmue · Pull Request #897 · mlcommons/inference · GitHub

/ inference Public

use host_processors_per_node in final report - #897

Merged
christ1ne merged 4 commits into
r1.0from
gs/fix-num-proc
Apr 6, 2021
ConversationCommits (4)ChecksFiles changed
Merged

use host_processors_per_node in final report#897
christ1ne merged 4 commits into
r1.0from
gs/fix-num-proc

Conversation

guschmue commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

guschmue requested a review from christ1ne March 30, 2021 14:55

christ1ne commented Mar 30, 2021

Copy link
Copy Markdown
Contributor

@guschmue should it be number_of_nodes * host_processors_per_node to be future proof on multi-node submissions?

guschmue commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

I could change it. But if I look at the nvidia results in 0.7 we have not done it there
https://mlperf.org/inference-results-0-7
But since number of nodes is not in the results table I guess we should.

guschmue commented Apr 5, 2021

Copy link
Copy Markdown
Contributor Author

ok, dividing by node count now.

christ1ne commented Apr 5, 2021

Copy link
Copy Markdown
Contributor

@guschmue should it be number_of_nodes * host_processors_per_node instead of number_of_nodes / host_processors_per_node? thanks!

guschmue commented Apr 6, 2021

Copy link
Copy Markdown
Contributor Author

ups. fixed. In practice for inference num_nodes is so far always 1 - would be hard to do multi node because of loadgen.

christ1ne commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

agree. :)

christ1ne merged commit 8b58587 into r1.0 Apr 6, 2021
github-actions Bot locked and limited conversation to collaborators Apr 6, 2021
guschmue deleted the gs/fix-num-proc branch July 12, 2021 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
christ1ne christ1ne approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL