| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
| cc = "1.0" | ||
| cfg-if = "1.0" | ||
| pkg-config = "0.3.17" | ||
| system-deps = "7.0" |
There was a problem hiding this comment.
Distro packager hat on here. How exactly does the system-deps crate go about determining if the appropriate headers and sources are installed on a host system? If this isn't using pkg-config under the hood somewhere (it may be) then this feels like a regression. If it's just an ergonomic wrapper around the same tooling that's probably fine, but it it is some bespoke hand rolled detection system this would be a huge red flag.
Sorry, something went wrong.
There was a problem hiding this comment.
There are two separate changes - adding metadata for parsing by any tool (easier than going through code) and one to use the added metadata for pkg-config's probe() calls:
For my use case, the first commit is enough but system-deps can use it to call pkg-config's probe() and we can avoid repeating the same info in the code, hence the second commit.
Please let me know if I missed something.
Sorry, something went wrong.
|
Its ready now. Removed optional = true and changed fallback_names order to match original behavior (fail when no feature is picked and keep old order of fallbacks). Can make it one commit instead if that is better. |
Sorry, something went wrong.
|
@alerque: Did not want to bump to add work. Please review and merge when free - updated to lua 5.5. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Will help in ci environments to know which system dependency to install based on feature.