FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

use NtSetInformationFile if os.Rename fails by karman-docker · Pull Request #220 · moby/sys · GitHub

/ sys Public

use NtSetInformationFile if os.Rename fails - #220

Open
karman-docker wants to merge 2 commits into
moby:mainfrom
karman-docker:add_retry_for_rename
ConversationCommits (2)ChecksFiles changed
Open

use NtSetInformationFile if os.Rename fails#220
karman-docker wants to merge 2 commits into
moby:mainfrom
karman-docker:add_retry_for_rename

Conversation

karman-docker commented Apr 30, 2026

Copy link
Copy Markdown

This PR adds atomicwriterRenameAt which uses NtSetInformationFile to rename a file on Windows.

use NtSetInformationFile if os.Rename fails
f141cb9 
Signed-off-by: Manju Karikatti <manju.karikatti@docker.com>
kolyshkin reviewed May 29, 2026
View reviewed changes
Comment thread atomicwriter/atomicwriter_unix.go Outdated

kolyshkin commented May 29, 2026

Copy link
Copy Markdown
Collaborator

This obviously needs some windows-specific tests.

kolyshkin reviewed Jun 14, 2026
View reviewed changes

kolyshkin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nit: you've introduced atomicwriterRenameAt in the first commit, and then rename it to atomicwriterRename in the second commit. Why not use the right name from the start?

nit: stuttering at the name (atomicwriter.atomicwriterRename).

karman-docker commented Jun 14, 2026

Copy link
Copy Markdown
Author

nit: you've introduced atomicwriterRenameAt in the first commit, and then rename it to atomicwriterRename in the second commit. Why not use the right name from the start?

nit: stuttering at the name (atomicwriter.atomicwriterRename).

sorry I thought in your initial review comment, you suggested to remove 'At' ?

kolyshkin commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

nit: you've introduced atomicwriterRenameAt in the first commit, and then rename it to atomicwriterRename in the second commit. Why not use the right name from the start?
nit: stuttering at the name (atomicwriter.atomicwriterRename).

sorry I thought in your initial review comment, you suggested to remove 'At' ?

Yes, but here I'm not saying At should be back, I am saying the right name should be introduced from the start, i.e. in the first commit.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kolyshkin kolyshkin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL