FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update clip wrapper and standardise CRS handling by irm-codebase · Pull Request #18 · modelblocks-org/module_area_potentials · GitHub

Update clip wrapper and standardise CRS handling - #18

Open
irm-codebase wants to merge 7 commits into
mainfrom
feature/improved-clipping
Open

Update clip wrapper and standardise CRS handling#18
irm-codebase wants to merge 7 commits into
mainfrom
feature/improved-clipping

Conversation

irm-codebase commented Aug 12, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #17, #16, #19

Summary of changes in this pull request

  • updated the clip wrapper version, and switched to using it for local files. This makes one script unnecessary.
  • Small tune up to naming of configuration (slope -> slope_deg)
  • Set flooded areas as NOT_SUITABLE by default (these are mostly swamps, wetlands or estuaries).
  • Standardisation to EPSG:4326 is explicit in settings.yaml. The implementation in minimal on purpose. This could be made fully flexible later.

Reviewer checklist

  • There are no pip dependencies in the module's environment files (workflow/envs/).
  • All rules use pathvars (e.g., <results>) in their inputs and outputs.
  • The integration test-suite is successful, including:
    • pre-commit.ci tests pass.
    • tests pass for all relevant OS configurations (linux, osx, windows).
  • Module documentation is up-to-date, including:
    • INTERFACE.yaml mentions all relevant pathvars and wildcards.
    • README.md describes how to use the module and has the necessary citations.

irm-codebase changed the title Update clip wrapper and replace clip script Update clip wrapper and standardise CRS handling Aug 13, 2026

jnnr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good! I reviewed, but haven't tested. Let me know if I should!

Comment thread INTERFACE.yaml Outdated
Co-authored-by: Jann Launer <32454596+jnnr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update clip wrapper to v9.14.0/geo/rasterio/clip

2 participants


Back | FazBrowse Home | New Git URL