Repository navigation
Rename MinVersionForStandardHeaders to DraftProtocolVersion - #1603
Merged
halter73 merged 3 commits intoJun 2, 2026
Merged
halter73 merged 3 commits into
halter73 merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The constant in src/Common/McpHttpHeaders.cs now gates more than just whether the standard MCP request headers are required: it also gates whether resources/read returns InvalidParams (-32602) instead of the legacy ResourceNotFound (-32002). Its old name referred only to headers, and the `Min` prefix wrongly implied an ordered/`>=` comparison even though the helpers do exact ordinal matches against a single value. Rename the constant to `DraftProtocolVersion` and update its XML docs to describe both gated behaviors. Pure rename plus doc clarification -- no behavior change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the draft protocol version gate constant in McpHttpHeaders to better reflect its broadened role (not just header enforcement) and clarifies the associated XML documentation.
Changes:
- Renamed MinVersionForStandardHeaders → DraftProtocolVersion (value unchanged: "DRAFT-2026-v1").
- Expanded the XML docs to describe both gated behaviors (standard header enforcement and resources/read error-code selection).
- Updated the in-file references to use the new constant name.
| File | Description |
|---|---|
| src/Common/McpHttpHeaders.cs | Renames the draft protocol version gate constant and updates documentation/references accordingly. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
Sorry, something went wrong.
tarekgh
previously approved these changes
May 26, 2026
tarekgh
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
tarekgh
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #1558.
That PR added a second use of the MinVersionForStandardHeaders constant in src/Common/McpHttpHeaders.cs — it now gates both:
The old name referred only to headers, so it no longer reflects the constant's broader role. The Min... prefix was also misleading: it implied an ordered/>= comparison, even though the helpers (SupportsStandardHeaders, UseInvalidParamsForMissingResource) just do exact ordinal matches against a single-element set.
Changes
Not changed
Validation