Repository navigation
fix(server): close register-after-sweep race on disposal - #1860
Open
jstar0 wants to merge 1 commit into
Open
jstar0 wants to merge 1 commit into
jstar0 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
DisposeAsync cancelled the MRTR continuations present when it iterated _mrtrContinuations. A continuation published after that iteration escaped cancellation entirely and could outlive the server. Add a server-lifetime CancellationTokenSource, cancel it at the very start of DisposeAsync — before the session handler is disposed and before the sweep — and re-check it immediately after publishing a continuation. Either the sweep sees the entry or the publisher sees the cancellation, so every interleaving cancels the handler. The issue proposed linking each handler's CTS to the server-lifetime token instead. That would leak: the per-handler source is deliberately never disposed, so a registration on a server-lifetime token is never released and accumulates for every MRTR handler invocation the process ever runs. The existing link to the per-request token is released when the request's source is disposed, which is why it does not accumulate today. Publish-then-recheck closes the same race without holding any per-request state on a process-lifetime token.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1707
Summary
Why
DisposeAsync previously cancelled the continuations present when it iterated _mrtrContinuations. A continuation published after that iteration could escape cancellation and remain active after server disposal.
Testing
No documentation changes are needed for this internal lifecycle fix.