Repository navigation
docs(core): document String structuredContent parsing in JsonSchemaValidator - #1111
Merged
Kehrlann merged 1 commit intoAug 27, 2026
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks for the docs update. Fixes #1110 |
Sorry, something went wrong.
Kehrlann
approved these changes
Aug 27, 2026
slachiewicz
added a commit
to slachiewicz/mcp-java-sdk
that referenced
this pull request
Aug 27, 2026
…d upstream, A5 closed
slachiewicz
added a commit
to slachiewicz/mcp-java-sdk
that referenced
this pull request
Sep 3, 2026
…ing configurable Listings are scoped private, not public. tools/list is filtered per caller (modelcontextprotocol#1111), so a shared cache must never serve one principal's listing to another; do not restore PUBLIC without gating it on the absence of a list filter. Client-side, the cache lookup moved inside Mono.defer so an assembled Mono stays cold, a generation counter drops a response that was in flight when its group was invalidated, and a listing spanning several pages is not cached at all, because stitching a cached first page to a freshly fetched later page mixes two server snapshots. ttlMs is validated on the result builders rather than in the compact constructor: a bad server hint must not make the whole listing unparseable. McpClientCacheStore keeps a Caffeine or shared-store implementation a user choice, so mcp-core stays at its three compile dependencies.
slachiewicz
added a commit
to slachiewicz/mcp-java-sdk
that referenced
this pull request
Sep 7, 2026
…ing configurable Listings are scoped private, not public. tools/list is filtered per caller (modelcontextprotocol#1111), so a shared cache must never serve one principal's listing to another; do not restore PUBLIC without gating it on the absence of a list filter. Client-side, the cache lookup moved inside Mono.defer so an assembled Mono stays cold, a generation counter drops a response that was in flight when its group was invalidated, and a listing spanning several pages is not cached at all, because stitching a cached first page to a freshly fetched later page mixes two server snapshots. ttlMs is validated on the result builders rather than in the compact constructor: a bad server hint must not make the whole listing unparseable. McpClientCacheStore keeps a Caffeine or shared-store implementation a user choice, so mcp-core stays at its three compile dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this change does
Adds the input-conversion contract of the validate method to the
JsonSchemaValidator interface Javadoc.
The method treats a String argument as a serialized JSON document and parses
it with readTree before validation. It converts any other type directly with
valueToTree. Both consequences follow for callers:
represents the value red.
parsing fails with a message that mentions the tool JSON Schema, even though
the schema is valid.
This contract exists identically in both implementations
(mcp-json-jackson2 at line 70, mcp-json-jackson3 at line 69). The interface
Javadoc did not state it before this change.
Why
During output-schema validation testing, a root-level enum check failed in a
way that pointed at the schema parser rather than at caller-side string
handling. Tracing both default validators revealed the undocumented branch.
Documentation-only changes to a shared SPI carry no migration risk, and the
wording mirrors what the code does so future refactors can update one place.
Testing
No production code changed. Before opening this pull request, I verified:
Notes for reviewers
If you prefer stronger ergonomics over pure documentation (for example, a
dedicated overload or a clearer parse-failure message), this wording still
stands on its own. Follow-up issues can adjust either message or API without
conflict. Known sharp edge, intentionally out of scope here: the
"Error parsing tool JSON Schema" prefix also appears when the content fails
to parse; existing test assertions pin that string in both modules.