Repository navigation
fix: race condition in ResponseSubscribers - #1152
Open
nickcaballero wants to merge 1 commit into
Open
nickcaballero wants to merge 1 commit into
nickcaballero wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR fixes a race condition in the io.modelcontextprotocol.client.transport.ResponseSubscribers. The root of the issue is that AggregateSubscriber and BodilessResponseLineSubscriber use a flag to determine if data was requested, but the flag is set after propagating the request to the source subscription. If the source subscription emits the requested data on the calling thread (or really fast), then hookOnComplete won't flush the buffered data.
Related #501.
How Has This Been Tested?
Added a unit test to confirm behavior.
Breaking Changes
N/A
Types of changes
Checklist
Additional context