FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Flush headers for idle Streamable HTTP GET requests by karthiksenv · Pull Request #1159 · modelcontextprotocol/java-sdk · GitHub

  1. modelcontextprotocol
  2. java-sdk

Repository navigation

Flush headers for idle Streamable HTTP GET requests #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karthiksenv wants to merge 2 commits into
base: main
Choose a base branch
Could not load branches
Branch not found: {{ refName }}

Are you sure you want to change the base?

Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
from
+23 −0
Conversation 0 Commits 2 Checks 0 Files changed 3
Open

Flush headers for idle Streamable HTTP GET requests #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6124bd7
Flush streamable HTTP GET headers
karthiksenv Oct 3, 2026
980e6a2
Add required AI contribution disclosure
karthiksenv Oct 3, 2026
File filter

Filter by extension

Filter by extension .java  (2) .txt  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
1 change: 1 addition & 0 deletions disclosure.txt
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This change was submitted despite me reading the rules and understanding AI contribution guidelines.
1 change: 1 addition & 0 deletions ...o/modelcontextprotocol/server/transport/HttpServletStreamableServerTransportProvider.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response)
.listeningStream(sessionTransport);

registerAsyncLifecycle(asyncContext, sessionId, listeningStream::releaseTransport);
response.flushBuffer();
}
catch (Exception e) {
logger.error("Failed to handle GET request for session {}: {}", sessionId, e.getMessage());
Expand Down
21 changes: 21 additions & 0 deletions ...t/src/test/java/io/modelcontextprotocol/server/HttpServletStreamableIntegrationTests.java
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import java.util.Queue;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentLinkedQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Function;
import java.util.stream.Stream;
Expand Down Expand Up @@ -450,6 +451,26 @@ void sessionIsNotEvictedWithoutSweepInterval() {
}
}

@Test
void getStreamSendsHeadersBeforeFirstEvent() throws Exception {
withTransportProvider(null, null);
String sessionId = initializeSession(httpClient);

var get = HttpRequest.newBuilder()
.uri(URI.create("http://localhost:" + PORT + MESSAGE_ENDPOINT))
.header("Accept", "text/event-stream")
.header(HttpHeaders.MCP_SESSION_ID, sessionId)
.GET()
.build();

HttpResponse<InputStream> response = httpClient.sendAsync(get, HttpResponse.BodyHandlers.ofInputStream())
.get(5, TimeUnit.SECONDS);

assertThat(response.statusCode()).isEqualTo(HttpServletResponse.SC_OK);
assertThat(response.headers().firstValue("Content-Type").orElse("")).startsWith("text/event-stream");
response.body().close();
}

/**
* A client which aborts a tool call must not leave its session behind.
*/
Expand Down
Back | FazBrowse Home | New Git URL