fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId - #802
Open
themaherkhalil wants to merge 4 commits into
Open
fix: ensuring the automatic module name is a valid name by replacing the - to . in artifactId#802themaherkhalil wants to merge 4 commits into
themaherkhalil wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Also including previous comment requesting the change as well: #739 (comment) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally closed my previous PR #739 - resolved the merge conflict but the below description is still valid.
Currently the jar's automatic module name is invalid as it contains a - in the artifactId. If you run:
➜ 0.17.0 jar --describe-module --file mcp-core-0.17.0.jar Unable to derive module descriptor for: mcp-core-0.17.0.jar Automatic-Module-Name: io.modelcontextprotocol.sdk.mcp-core: Invalid module name: 'mcp-core' is not a Java identifierThis prevents other projects using modules to import the jar.
The change is to replace the - with a .
After compiling the code to build the jar, running the command will produce: