FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: NumberSchema min/max/default should be number, not integer by gsdv · Pull Request #2710 · modelcontextprotocol/modelcontextprotocol · GitHub

  1. modelcontextprotocol
  2. modelcontextprotocol

Repository navigation

fix: NumberSchema min/max/default should be number, not integer #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsp-ant merged 4 commits into from
May 29, 2026
Conversation 1 Commits 4 Checks 5 Files changed
Merged

fix: NumberSchema min/max/default should be number, not integer #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c203787
Using number for NumberSchema min/max/default, not integer.
gsdv May 11, 2026
4117331
Merge branch 'main' into fix/number-schema-integer-type
gsdv May 14, 2026
83e2dfd
remove chnges to non-draft versions
dsp-ant May 29, 2026
cf0ba9d
add changelog entry
dsp-ant May 29, 2026
File filter

Filter by extension

Filter by extension .json  (1) .mdx  (1) .ts  (1) All 3 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion docs/specification/draft/changelog.mdx
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ the previous revision, [2025-11-25](/specification/2025-11-25).

## Other schema changes

N/A
1. `schema.json` now correctly reflects that the Typescript definition of wminimum/maximum/default are `number`'s and not just `integers`. This was casued by using the generator using `--defaultNumberType integer` ([PR#2710](https://github.com/modelcontextprotocol/modelcontextprotocol/pull/2710)).

## Governance and process updates

Expand Down
6 changes: 3 additions & 3 deletions schema/draft/schema.json
Show comments
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions schema/draft/schema.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3027,8 +3027,17 @@ export interface NumberSchema {
type: "number" | "integer";
title?: string;
description?: string;
/**
* @TJS-type number
*/
minimum?: number;
/**
* @TJS-type number
*/
maximum?: number;
/**
* @TJS-type number
*/
default?: number;
}

Expand Down
Loading
Back | FazBrowse Home | New Git URL