Repository navigation
Make "resource" optional on earlier protocols - #1017
Merged
ihrpr merged 1 commit intoJun 25, 2025
Merged
ihrpr merged 1 commit into
ihrpr merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@pcarleton it seems like my implementation is more narrow than yours as I only exclude "resource" if it's also an older protocol |
Sorry, something went wrong.
pcarleton
approved these changes
Jun 25, 2025
pcarleton
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm, thanks!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make "resource" optional on earlier protocols in order to remain backwards compatible with servers on earlier versions.
Motivation and Context
#991 introduced breaking changes for servers on earlier protocol versions that don't support the resource param. This change requires the param only if either is true: PRM is available or the protocol is 2025-06-18 or later.
How Has This Been Tested?
unit tests
Breaking Changes
None
Types of changes
Checklist
Additional context