Add regression test for issue #1027 - #1069
Merged
bhosmer-ant merged 1 commit intoJul 8, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
felixweinberger
changed the base branch from
main
to
fweinberger/stream-cleanup-only-approach
July 1, 2025 20:29
felixweinberger
force-pushed
the
fweinberger/issue-1027
branch
from
0e4626a to
c032dbc
Compare
July 1, 2025 20:30
2 tasks
felixweinberger
marked this pull request as ready for review
July 1, 2025 20:35
felixweinberger
force-pushed
the
fweinberger/issue-1027
branch
4 times, most recently
from
1224de0 to
3c8eabe
Compare
July 1, 2025 20:48
felixweinberger
force-pushed
the
fweinberger/stream-cleanup-only-approach
branch
12 times, most recently
from
7af9e65 to
c9b43bc
Compare
July 7, 2025 13:59
felixweinberger
force-pushed
the
fweinberger/issue-1027
branch
from
3c8eabe to
72cfeca
Compare
July 7, 2025 15:03
felixweinberger
marked this pull request as draft
July 7, 2025 15:03
felixweinberger
force-pushed
the
fweinberger/issue-1027
branch
from
72cfeca to
526d276
Compare
July 8, 2025 16:39
felixweinberger
changed the base branch from
main
to
fweinberger/align-shutdown-with-spec
July 8, 2025 16:39
felixweinberger
force-pushed
the
fweinberger/issue-1027
branch
5 times, most recently
from
79ebf22 to
34643bd
Compare
July 8, 2025 19:35
This test shows that MCP server cleanup code in lifespan doesn't run when the process is terminated, but does run when stdin is closed first (as implemented in PR #1044). The test includes: - Demonstration of current broken behavior (cleanup doesn't run) - Verification that stdin closure allows graceful shutdown - Windows-specific ResourceWarning handling - Detailed documentation of the issue and solution Github-Issue:#1027
felixweinberger
force-pushed
the
fweinberger/issue-1027
branch
from
34643bd to
26e1e49
Compare
July 8, 2025 19:44
felixweinberger
marked this pull request as ready for review
July 8, 2025 19:48
bhosmer-ant
approved these changes
Jul 8, 2025
bhosmer-ant
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Excellent, LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue #1027 reports that MCP server cleanup code (after yield in lifespan) is unreachable when the process is terminated. This PR adds tests that:
How Has This Been Tested?
Added two tests in test_1027_win_unreachable_cleanup.py:
Tested on both macOS and Windows.
When run with PR #1091's changes, both tests pass.
Breaking Changes
None. Tests only.
Types of changes
Checklist
Additional context