FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Close server session after handle stateless request by hopeful0 · Pull Request #1116 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Close server session after handle stateless request #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixweinberger merged 2 commits into from
Jul 14, 2025
+5 −2
Conversation 10 Commits 2 Checks 10 Files changed 2
Merged

Close server session after handle stateless request #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
342a6b5
Close server session after handle stateless request
hopeful0 Jul 10, 2025
826ec0a
Rename _terminate_session to terminal in StreamableHTTPServerTransport
hopeful0 Jul 14, 2025
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
4 changes: 2 additions & 2 deletions src/mcp/server/streamable_http.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -612,15 +612,15 @@ async def _handle_delete_request(self, request: Request, send: Send) -> None:
if not await self._validate_request_headers(request, send):
return

await self._terminate_session()
await self.terminate()

response = self._create_json_response(
None,
HTTPStatus.OK,
)
await response(request.scope, request.receive, send)

async def _terminate_session(self) -> None:
async def terminate(self) -> None:
"""Terminate the current session, closing all streams.

Once terminated, all requests with this session ID will receive 404 Not Found.
Expand Down
3 changes: 3 additions & 0 deletions src/mcp/server/streamable_http_manager.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,9 @@ async def run_stateless_server(*, task_status: TaskStatus[None] = anyio.TASK_STA
# Handle the HTTP request and return the response
await http_transport.handle_request(scope, receive, send)

# Terminate the transport after the request is handled
await http_transport.terminate()
Comment on lines 191 to +194

Kludex Jul 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can handle_request fail? I didn't check, but I think ideally this transport should run in a context manager, which would terminate on exit.

hopeful0 Jul 15, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I agree that handle_request might fail, perhaps we could use try...finally... to handle this situation. Context managers may not be suitable for stateful requests.

async def _handle_stateful_request(
self,
scope: Scope,
Expand Down
Loading
Back | FazBrowse Home | New Git URL