Fix workspace configuration error with structured_output_lowlevel.py - #1259
Closed
lorenss-m wants to merge 2 commits into
Closed
Fix workspace configuration error with structured_output_lowlevel.py#1259lorenss-m wants to merge 2 commits into
lorenss-m wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lorenss-m
force-pushed
the
pr/workspace-fix
branch
from
1adbef7 to
48f2deb
Compare
August 10, 2025 21:19
felixweinberger
requested changes
Sep 23, 2025
felixweinberger
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
HI @lorenss-m thanks for this contribution!
This change looks good to me and is a nice clean-up - just left a comment on the pyproject.toml for something I don't think we need to have in this PR?
Sorry, something went wrong.
Comment thread
examples/servers/structured-output-lowlevel/pyproject.toml
Comment on lines
+8
to
+9
| [tool.uv.sources] | ||
| mcp = { workspace = true } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Do we actually need this? I don't think any of the other examples have this.
Sorry, something went wrong.
9 tasks
Copy link
Copy Markdown
Contributor
|
Closing in favor of #1471 - thanks again for this contribution! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The workspace configuration in pyproject.toml uses glob pattern examples/servers/* expecting all items to be packages with their own pyproject.toml. However, structured_output_lowlevel.py is a standalone file, causing uv sync to fail when installing the SDK as a git dependency.
How Has This Been Tested?
Breaking Changes
None. The example functionality remains identical.
Types of changes
Checklist
Additional context
Moved examples/servers/structured_output_lowlevel.py to examples/servers/structured-output-lowlevel/mcp_structured_output_lowlevel/__main__.py with proper package structure.