FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use proper sync resolution in CI by Kludex · Pull Request #1325 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Use proper sync resolution in CI - #1325

Closed
Kludex wants to merge 2 commits into
mainfrom
fix-pipeline
ConversationCommits (2)ChecksFiles changed
Closed

Use proper sync resolution in CI#1325
Kludex wants to merge 2 commits into
mainfrom
fix-pipeline

Conversation

Kludex commented Aug 30, 2025

Copy link
Copy Markdown
Member

No description provided.

Kludex requested review from a team and dsp-ant August 30, 2025 21:01
Kludex mentioned this pull request Aug 30, 2025
Merged
4 tasks

Kludex commented Aug 30, 2025

Copy link
Copy Markdown
Member Author

@maxisbey Do you have time to debug this?

maxisbey commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

@maxisbey Do you have time to debug this?

Pretty sure it's because of this function here:

python-sdk/tests/client/test_config.py

Line 26 in 5439619

def test_command_execution(mock_config_path: Path):

It runs a uv command built here:

python-sdk/src/mcp/cli/claude.py

Line 67 in 4fee123

uv_path = get_uv_path()

This is then run without uv --frozen and without whatever dependency resolution is being set by the changes you made in this PR. So the unit test times out since it's re-installing a bunch of dependencies due to the different dependency version resolution uv is using when launched inside the unit test.

felixweinberger added the needs more work Not ready to be merged yet, needs additional follow-up from the author(s). label Sep 23, 2025

felixweinberger commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

Will pick this up from @ihrpr

felixweinberger added the needs maintainer Potentially serious issue - needs proactive fix and maintainer attention label Sep 23, 2025
felixweinberger self-assigned this Sep 23, 2025
felixweinberger added this to the CI & Testing milestone Sep 30, 2025
felixweinberger removed their assignment Oct 10, 2025
felixweinberger mentioned this pull request Oct 22, 2025
Merged
9 tasks

felixweinberger commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Closing in favor of #1507

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dsp-ant Awaiting requested review from dsp-ant

Assignees

No one assigned

Labels

needs maintainer Potentially serious issue - needs proactive fix and maintainer attention needs more work Not ready to be merged yet, needs additional follow-up from the author(s).

Projects

None yet

Milestone

CI & Testing

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL