FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add workflow to comment on PRs when released by yugannkt · Pull Request #1772 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Add workflow to comment on PRs when released - #1772

Merged
maxisbey merged 5 commits into
modelcontextprotocol:mainfrom
yugannkt:feat/pr-release-notification-workflow
Dec 19, 2025
ConversationCommits (5)ChecksFiles changed
Merged

Add workflow to comment on PRs when released#1772
maxisbey merged 5 commits into
modelcontextprotocol:mainfrom
yugannkt:feat/pr-release-notification-workflow

Conversation

yugannkt commented Dec 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation and Context

Adds a workflow that automatically comments on PRs when they're included in a release, notifying contributors their changes are live.

Approach

Custom workflow using GitHub's REST API:

  1. Triggers on release published
  2. Compares current and previous release tags
  3. Extracts PR numbers from commits
  4. Validates each is a merged PR (not an issue) via API
  5. Comments on each PR: "🎉 This pull request is included in v1.23.3!"

Key Features

Only comments on PRs (not issues) - API validation ensures this
Minimal permissions - only pull-requests: write required

How Has This Been Tested?

Tested with releases v1.23.2 → v1.23.3:

Fixes #1759

Breaking Changes

No, Its an non-breaking change which adds functionality

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Add workflow to comment on PRs when released
2a021eb 
- Automatically comments on PRs included in a release
- Only comments on PRs (not issues) using GitHub API validation
- Compares current and previous release tags to find PRs
- Minimal permissions: only requires pull-requests:write

Fixes modelcontextprotocol#1759
fix: Apply prettier formatting
1c601d1

yugannkt commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

Ready for your review @maxisbey

maxisbey added enhancement Request for a new feature that's not currently supported P3 Nice to haves, rare edge cases labels Dec 11, 2025
felixweinberger requested changes Dec 11, 2025
View reviewed changes
Comment thread .github/workflows/comment-on-release.yml Outdated
Comment thread .github/workflows/comment-on-release.yml Outdated
Comment thread .github/workflows/comment-on-release.yml Outdated
Comment thread .github/workflows/comment-on-release.yml Outdated
Comment thread .github/workflows/comment-on-release.yml
felixweinberger reviewed Dec 11, 2025
View reviewed changes
Comment thread .github/workflows/comment-on-release.yml Outdated

yugannkt commented Dec 13, 2025

Copy link
Copy Markdown
Contributor Author

Ready for your review @felixweinberger

felixweinberger approved these changes Dec 15, 2025
View reviewed changes

felixweinberger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Comment thread .github/workflows/comment-on-release.yml
Comment on lines +17 to +18
with:
fetch-depth: 0

felixweinberger Dec 15, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't think we need this anymore given we're now using the API only?

felixweinberger commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Ready for your review @felixweinberger

Thanks! Code LGTM, but curious how you tested this? Did you run this locally somehow to generate the PRs?

maxisbey commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Will merge this for now and we can validate it works on the next release (will be in Jan)

maxisbey merged commit 4807eb5 into modelcontextprotocol:main Dec 19, 2025
18 checks passed

Kludex commented Dec 19, 2025

Copy link
Copy Markdown
Member

If people want to be notified, they can watch the releases... 😅

yugannkt commented Dec 21, 2025

Copy link
Copy Markdown
Contributor Author

Thanks! Code LGTM, but curious how you tested this? Did you run this locally somehow to generate the PRs?

Hy @maxisbey
I tested this by running the workflow in my fork using GitHub Actions:

  1. Pushed the workflow to my fork
  2. Modified the trigger temporarily to run on workflow_dispatch (manual trigger)
  3. Hardcoded the release tags v1.23.2 → v1.23.3 to simulate a release event
  4. The workflow ran against the upstream repo's data (since the commit SHAs and releases are the same)
  5. Successfully detected the 5 PRs merged between those releases
  6. The actual commenting step failed with a 403 error (as expected) because my fork's GITHUB_TOKEN doesn't have permission to comment on the upstream repo's PRs. But the PR detection logic was fully validated.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

felixweinberger felixweinberger approved these changes
maxisbey maxisbey approved these changes

Assignees

No one assigned

Labels

enhancement Request for a new feature that's not currently supported P3 Nice to haves, rare edge cases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add workflow to comment on PRs when released (PRs only, not issues)

4 participants

Back | FazBrowse Home | New Git URL