FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: `handle_sse_response` causing dangling client's read_stream by ivanbelenky · Pull Request #1812 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

fix: handle_sse_response causing dangling client's read_stream - #1812

Closed
ivanbelenky wants to merge 2 commits into
modelcontextprotocol:mainfrom
ivanbelenky:main
ConversationCommits (2)ChecksFiles changed
Closed

fix: handle_sse_response causing dangling client's read_stream #1812
ivanbelenky wants to merge 2 commits into
modelcontextprotocol:mainfrom
ivanbelenky:main

Conversation

ivanbelenky commented Dec 21, 2025

Copy link
Copy Markdown

Notifying session layer on transport error. Sending the error to the client's read_stream_writer.

Motivation and Context

Indefinitely hang described on issue #1811

How Has This Been Tested?

Running suite of tests locally as per contribution guidelines.

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

ivanbelenky changed the title draft commit of solution to issue #1811 fix: handle_sse_response causing dangling client's read_stream Dec 21, 2025
ivanbelenky marked this pull request as ready for review December 23, 2025 03:28
ivanbelenky mentioned this pull request Dec 23, 2025
Open
maxisbey added bug Something isn't working P1 Significant bug affecting many users, highly requested feature labels Dec 31, 2025

heyhayes commented Feb 21, 2026

Copy link
Copy Markdown

Hey @ivanbelenky — thanks for identifying this root cause, your analysis was spot on. PR #2122 covers the same fix (sending a JSONRPCError when the SSE stream ends without a response) and also addresses the infinite reconnection loop in _handle_reconnection and handle_get_stream that was reported in #1789. Just wanted to flag the overlap so we don't duplicate effort.

ivanbelenky commented Feb 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Just wanted to flag the overlap so we don't duplicate effort.

Thanks @heyhayes, based on the non immediate action over this issue + PR by maintainers, I just used my fork and stopped work. Closing this as soon as any of the 2 gets merged.

maxisbey commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR. This has since landed via #3047. Closing this as part of a wider backlog cleanup following the v2 launch. If it's still relevant, feel free to reopen.

AI Disclaimer

maxisbey closed this Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working P1 Significant bug affecting many users, highly requested feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL