Fix AttributeError when tool fields are None in OpenAI Agents SDK instrumentation (#1285) - #2347
Closed
YouFoxGirl wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…trumentation In get_response_tool_web_search_attributes() and get_response_tool_file_search_attributes(), hasattr() returns True for optional fields set to None, but accessing .__dict__ on None raises AttributeError. Added is not None guard for user_location, filters, and ranking_options fields. Fixes modelcontextprotocol#1285
Copy link
Copy Markdown
Contributor
|
Closing — this adds files under agentops/instrumentation/..., which doesn't exist in this repo. It looks like this PR was intended for a different project. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In get_response_tool_web_search_attributes() and get_response_tool_file_search_attributes(), hasattr() returns True for optional fields set to None, but accessing .__dict__ on None raises AttributeError.
Fix
Added is not None guard for user_location, filters, and ranking_options fields in agentops/instrumentation/providers/openai/attributes/response.py:
Same pattern applied to filters and ranking_options.
Testing
Added regression tests in tests/unit/instrumentation/providers/openai/test_response_issue_1285.py covering all three None-field cases. All 5 tests pass.
Fixes #1285