FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix SSE timeout hang by propagating transport exceptions to pending r… by widgetwalker · Pull Request #2430 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Fix SSE timeout hang by propagating transport exceptions to pending r… #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
widgetwalker wants to merge 3 commits into from
+18 −0
Conversation 7 Commits 3 Checks 25 Files changed 1
Closed

Fix SSE timeout hang by propagating transport exceptions to pending r… #2430

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b85e59
Fix SSE timeout hang by propagating transport exceptions to pending r…
Apr 13, 2026
58aca04
Potential fix for pull request finding
widgetwalker Apr 13, 2026
711aecd
Refine fix: explicitly pop and close response streams to avoid double…
Apr 13, 2026
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
18 changes: 18 additions & 0 deletions src/mcp/shared/session.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,24 @@ async def _handle_session_message(message: SessionMessage) -> None:
async for message in self._read_stream:
if isinstance(message, Exception):
await self._handle_incoming(message)

# Fix #1401: Propagate exception to all pending requests
# This prevents waiters from hanging when the transport fails
error_data = (
message.to_error_data()
if isinstance(message, MCPError)
else ErrorData(code=0, message=str(message))
)

# We must send an error to every individual waiter
for req_id, stream in list(self._response_streams.items()):
try:
# Send a response with the correct ID
await stream.send(JSONRPCError(jsonrpc="2.0", id=req_id, error=error_data))
finally:
# Ensure we clean up the stream so finally block doesn't double-handle
self._response_streams.pop(req_id, None)
await stream.aclose()
continue

Comment on lines +431 to 450
await _handle_session_message(message)
Expand Down
Loading
Back | FazBrowse Home | New Git URL