Drop AbstractAsyncContextManager for proper type hint to BaseSession - #257
Merged
dsp-ant merged 1 commit intoMar 11, 2025
Merged
Drop AbstractAsyncContextManager for proper type hint to BaseSession#257dsp-ant merged 1 commit into
dsp-ant merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
dsp-ant
approved these changes
Mar 11, 2025
Comment thread
src/mcp/shared/session.py
| import httpx | ||
| from anyio.streams.memory import MemoryObjectReceiveStream, MemoryObjectSendStream | ||
| from pydantic import BaseModel | ||
| from typing_extensions import Self |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Isn't this in typing as well?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
my bad, it's in typing in 3.11 not in 3.10
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can see that session assumes ClientSession type now.
The real problem is that AbstractAsyncContextManager is a generic, so it expects some type as an argument. We can't really add BaseClient as that type, because the return type from the ClientSession __aexit__ is not BaseClient, it's actually ClientSession.