| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Rebased this on current main and carried the crash-cause reporting over the updated streamable HTTP code. Validation run locally on Windows: python -m py_compile src\mcp\server\streamable_http.py src\mcp\server\streamable_http_manager.py tests\server\test_streamable_http_manager.py
uv run pytest tests/server/test_streamable_http_manager.py -q -k "session_crash_cause or post_error_message" --basetemp .tmp\pytest-2742-20260610 -p no:cacheprovider
# 2 passed, 20 deselected
git diff --check upstream/main..HEAD
The error log lines in that targeted pytest run are expected: the new regression test deliberately crashes the session runner and asserts that the JSON response reports the original session exception instead of only the downstream closed-stream error. |
Sorry, something went wrong.
|
Closing this. Since I opened it, main has reworked the streamable-HTTP POST error path in the opposite direction — it logs the exception server-side and returns a generic "Error handling POST request" message rather than surfacing the underlying error to the client. This PR's whole point was to surface the session crash cause, which now cuts against that deliberate choice, so it's cleaner to drop it than to force a conflicting reconcile. Thanks for the refactor. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Fixes #2741.
To verify