Extract protocol types into a standalone mcp-types package - #2762
Closed
Kludex wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Convert the repository into a uv workspace mirroring pydantic/httpx2. The root pyproject becomes a pure coordinator (package = false) and the two distributable packages live nested under src/<pkg>/<pkg>/ each with their own pyproject: - src/mcp/mcp/ -> mcp - src/mcp-types/mcp_types/ -> mcp-types (import mcp_types) The protocol types (_types.py, jsonrpc.py) move into mcp_types, which only depends on pydantic and typing-extensions. mcp depends on mcp-types via uv-dynamic-versioning, so installing mcp still pulls the types in. The mcp.types module path is removed; all imports now use mcp_types. The curated re-exports on the top-level mcp package are unchanged.
Copy link
Copy Markdown
Contributor
|
Closing — this was superseded by #2973 (merged, shipped in v2.0.0a3) plus the follow-ups in #2977. Main now carries the full mcp-types split, including pieces this branch predates (methods.py, _wire_base.py, the versioned validator packages). The one thing not adopted was the coordinator-root layout with mcp nested under src/mcp/mcp/ — if we still want that restructure it'd need a fresh PR against the current tree. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the repository into a uv workspace mirroring pydantic/httpx2, introducing a standalone mcp-types package for the protocol types.
Verification
AI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.