FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Run StreamableHTTP transport tests in process instead of over sockets by maxisbey · Pull Request #2767 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Run StreamableHTTP transport tests in process instead of over sockets #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxisbey merged 2 commits into from
Jun 3, 2026
+969 −1,177
Conversation 0 Commits 2 Checks 33 Files changed 3
Merged

Run StreamableHTTP transport tests in process instead of over sockets #2767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de72011
Run StreamableHTTP transport tests in process instead of over sockets
maxisbey Jun 2, 2026
f18d65b
Gate the multiple-reconnections test on observed reconnects, not sleeps
maxisbey Jun 3, 2026
File filter

Filter by extension

Filter by extension .py  (3) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
8 changes: 3 additions & 5 deletions src/mcp/server/streamable_http.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def close_sse_stream(self, request_id: RequestId) -> None:
send_stream.close()
receive_stream.close()

def close_standalone_sse_stream(self) -> None: # pragma: no cover
def close_standalone_sse_stream(self) -> None:
"""Close the standalone GET SSE stream, triggering client reconnection.

This method closes the HTTP connection for the standalone GET stream used
Expand All @@ -221,8 +221,6 @@ def close_standalone_sse_stream(self) -> None: # pragma: no cover
This is a no-op if there is no active standalone SSE stream.
Requires event_store to be configured for events to be stored during
the disconnect.
Currently, client reconnection for standalone GET streams is NOT
implemented - this is a known gap (see test_standalone_get_stream_reconnection).
"""
self.close_sse_stream(GET_STREAM_KEY)

Expand All @@ -245,7 +243,7 @@ def _create_session_message(
async def close_stream_callback() -> None:
self.close_sse_stream(request_id)

async def close_standalone_stream_callback() -> None: # pragma: no cover
async def close_standalone_stream_callback() -> None:
self.close_standalone_sse_stream()

metadata = ServerMessageMetadata(
Expand Down Expand Up @@ -421,7 +419,7 @@ async def _validate_accept_header(self, request: Request, scope: Scope, send: Se
has_json, has_sse = self._check_accept_headers(request)
if self.is_json_response_enabled:
# For JSON-only responses, only require application/json
if not has_json: # pragma: no cover
if not has_json:
response = self._create_error_response(
"Not Acceptable: Client must accept application/json",
HTTPStatus.NOT_ACCEPTABLE,
Expand Down
Loading
Loading
Back | FazBrowse Home | New Git URL