Fix 404 links in v1 README to renamed example files - #2822
Merged
maxisbey merged 2 commits intoJun 12, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The v1 README (frozen on main) links to examples/snippets/servers/ fastmcp_quickstart.py and examples/fastmcp/icons_demo.py on the main branch, but those files were renamed there as part of the FastMCP -> MCPServer rename, so both links now 404. Point them at the v1.x branch, where the files still exist and match the documented v1 API.
The remaining example links still resolved on main, but the files there were rewritten for v2 (FastMCP -> MCPServer), so they showed code that no longer matches the v1 API this README documents. Point every example link at v1.x, matching the two 404 fixes. The LICENSE link stays on main; the file is identical on both branches. Committed with SKIP=readme-v1-frozen like the previous commit.
maxisbey
approved these changes
Jun 11, 2026
maxisbey
enabled auto-merge (squash)
June 11, 2026 17:09
auto-merge was automatically disabled
June 12, 2026 13:59
Pull request was closed
Copy link
Copy Markdown
Contributor
|
This pull request is included in pre-release v2.0.0a2 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1 README.md (frozen on main until v2 ships) links to two example files on the main branch that were renamed as part of the FastMCP → MCPServer rename, so both links now 404:
This points both links at the v1.x branch instead, where the files still exist and match the v1 API the README documents.
No content changes to the frozen v1 docs — links only (committed with SKIP=readme-v1-frozen).
Verification
Checked every blob/main link in README.md against files on main — these were the only two missing. Confirmed both paths exist on v1.x via git ls-tree origin/v1.x.