Add GenAI semconv attributes to native OTel spans - #2854
Closed
etserend wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Here is example output tools/call
├── Span: 'MCP handle tools/call greet' kind=SERVER
│ trace_id: 0xbd62f33a2a8bca7fce981401e9e1fa37
│ ├── gen_ai.operation.name: 'execute_tool'
│ ├── gen_ai.tool.name: 'greet'
│ ├── jsonrpc.request.id: '1'
│ ├── mcp.method.name: 'tools/call'
│ └── rpc.system: 'mcp'
└── Span: 'MCP send tools/call greet' kind=CLIENT
trace_id: 0xbd62f33a2a8bca7fce981401e9e1fa37 ← same trace, context propagated
├── gen_ai.operation.name: 'execute_tool'
├── gen_ai.tool.name: 'greet'
├── jsonrpc.request.id: '1'
├── mcp.method.name: 'tools/call'
└── rpc.system: 'mcp'
tools/list
├── Span: 'MCP handle tools/list' kind=SERVER
│ trace_id: 0xb34caa9e9dbe2748b4b3e37847bd4545
│ ├── gen_ai.operation.name: 'list_tools'
│ ├── jsonrpc.request.id: '1'
│ ├── mcp.method.name: 'tools/list'
│ └── rpc.system: 'mcp'
└── Span: 'MCP send tools/list' kind=CLIENT
trace_id: 0xb34caa9e9dbe2748b4b3e37847bd4545
├── gen_ai.operation.name: 'list_tools'
├── jsonrpc.request.id: '1'
├── mcp.method.name: 'tools/list'
└── rpc.system: 'mcp'
resources/read
├── Span: 'MCP handle resources/read' kind=SERVER
│ trace_id: 0x6f0d7ecaaea9cb4453f7a9e453f923b6
│ ├── gen_ai.operation.name: 'read_resource'
│ ├── jsonrpc.request.id: '1'
│ ├── mcp.method.name: 'resources/read'
│ ├── mcp.resource.uri: 'test://greeting'
│ └── rpc.system: 'mcp'
└── Span: 'MCP send resources/read' kind=CLIENT
trace_id: 0x6f0d7ecaaea9cb4453f7a9e453f923b6
├── gen_ai.operation.name: 'read_resource'
├── jsonrpc.request.id: '1'
├── mcp.method.name: 'resources/read'
├── mcp.resource.uri: 'test://greeting'
└── rpc.system: 'mcp'
|
Sorry, something went wrong.
etserend
force-pushed
the
enrich-otel-spans-genai-semconv
branch
from
aa95d2b to
6930f92
Compare
June 12, 2026 20:59
adityamehra
reviewed
Jun 12, 2026
Comment thread
src/mcp/shared/_otel.py
Outdated
…, add gen_ai.prompt.name for prompts/get
etserend
force-pushed
the
enrich-otel-spans-genai-semconv
branch
from
e038fe2 to
5744777
Compare
June 15, 2026 14:21
etserend
marked this pull request as ready for review
June 15, 2026 15:52
2 tasks
Copy link
Copy Markdown
Contributor
|
Thanks for the PR. This has since landed via #2970. I'm closing this out as part of a backlog cleanup now that v2 is out. Feel free to reopen if this is still relevant. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing otel_middleware and client-side spans only emitted mcp.method.name and jsonrpc.request.id. This enriches them with attributes defined in the OTel GenAI MCP semantic conventions:
Motivation and Context
The SDK already ships otel_middleware in src/mcp/server/runner.py producing SpanKind.SERVER spans with W3C trace context propagation. Aligning the native span attributes with the GenAI semconv spec means every MCP-based framework and every distribution gets conformant telemetry without independently re-implementing span plumbing.
How Has This Been Tested?
Adds three tests to tests/shared/test_otel.py:
Types of changes
Checklist
Additional context