| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| Expand Up | @@ -18,7 +18,16 @@ env: | |
| # Use a published version, e.g. @modelcontextprotocol/conformance@0.2.0-alpha.7. | ||
| # Bump deliberately and reconcile both | ||
| # .github/actions/conformance/expected-failures*.yml files in the same change. | ||
| CONFORMANCE_PKG: "@modelcontextprotocol/conformance@0.2.0-alpha.7" | ||
| # | ||
| # Temporarily pinned to the pkg.pr.new preview build of conformance#371, which | ||
| # fixes the http-custom-headers fixture's spec-forbidden `number`-typed | ||
| # x-mcp-header annotations. Because this is a mutable URL (not a registry | ||
| # spec), CONFORMANCE_PKG_SHA256 pins the tarball and the fetch-and-verify step | ||
| # below downloads, checks the digest, and repoints CONFORMANCE_PKG at the | ||
| # verified local copy. Repin to the published release that includes #371 once | ||
| # it ships, then drop CONFORMANCE_PKG_SHA256 and the fetch-and-verify steps. | ||
| CONFORMANCE_PKG: "https://pkg.pr.new/@modelcontextprotocol/conformance@371" | ||
|
Comment thread
Comment on lines
+21
to
+29
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality[nit] URL-based CONFORMANCE_PKG reintroduced without the SHA256 fetch-and-verify step This repins CONFORMANCE_PKG to a pkg.pr.new URL but doesn't restore the CONFORMANCE_PKG_SHA256 env var and "Fetch and verify conformance harness" step that accompanied the previous URL-based pin (removed in #2974 only because it switched to a registry spec). npx --yes "$CONFORMANCE_PKG" now executes an unverified, mutable remote tarball in CI — a regression from the repo's own supply-chain posture for this exact pattern. Either restore the SHA256 + fetch-and-verify step from pre-#2974 (curl → sha256sum -c → repoint to file:/tmp/conformance.tgz), or keep the @0.2.0-alpha.7 registry pin and leave http-custom-headers in expected-failures until conformance#371 publishes.
Sorry, something went wrong.
All reactions
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityGood catch - restored the SHA256 + fetch-and-verify step from pre-#2974 (curl → sha256sum -c → repoint to file:/tmp/conformance.tgz) and pinned CONFORMANCE_PKG_SHA256 to the #371 tarball digest. So CI verifies the mutable URL rather than trusting it, and a re-push to #371 fails the digest check loudly. Kept the preview pin (not the alpha.7 + expected-failures option) so the scenario runs green now; will repin to the published release once #371 ships and drop the SHA + verify step then.
Sorry, something went wrong.
All reactions
|
||
| CONFORMANCE_PKG_SHA256: "9d8b25874d55e304b006cbaa066571773582f5828143c53a2b8a6830f203ca1d" | ||
|
|
||
| jobs: | ||
| server-conformance: | ||
| Expand All | @@ -34,6 +43,19 @@ jobs: | |
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: 24 | ||
| - name: Fetch and verify conformance harness | ||
| # Only when CONFORMANCE_PKG is a URL: download, check the recorded | ||
| # sha256, and re-point CONFORMANCE_PKG at the verified local tarball. | ||
| # When CONFORMANCE_PKG is a registry spec, this step is a no-op (npm's | ||
| # own integrity check applies). | ||
| run: | | ||
| case "$CONFORMANCE_PKG" in | ||
| https://*) | ||
| curl -fsSL "$CONFORMANCE_PKG" -o /tmp/conformance.tgz | ||
| echo "$CONFORMANCE_PKG_SHA256 /tmp/conformance.tgz" | sha256sum -c - | ||
| echo "CONFORMANCE_PKG=file:/tmp/conformance.tgz" >> "$GITHUB_ENV" | ||
| ;; | ||
| esac | ||
| - run: uv sync --frozen --all-extras --package mcp-everything-server | ||
| - name: Run server conformance (active suite) | ||
| run: >- | ||
| Expand Down Expand Up | @@ -65,6 +87,19 @@ jobs: | |
| - uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: 24 | ||
| - name: Fetch and verify conformance harness | ||
| # Only when CONFORMANCE_PKG is a URL: download, check the recorded | ||
| # sha256, and re-point CONFORMANCE_PKG at the verified local tarball. | ||
| # When CONFORMANCE_PKG is a registry spec, this step is a no-op (npm's | ||
| # own integrity check applies). | ||
| run: | | ||
| case "$CONFORMANCE_PKG" in | ||
| https://*) | ||
| curl -fsSL "$CONFORMANCE_PKG" -o /tmp/conformance.tgz | ||
| echo "$CONFORMANCE_PKG_SHA256 /tmp/conformance.tgz" | sha256sum -c - | ||
| echo "CONFORMANCE_PKG=file:/tmp/conformance.tgz" >> "$GITHUB_ENV" | ||
| ;; | ||
| esac | ||
| - run: uv sync --frozen --all-extras --package mcp | ||
| - name: Run client conformance (all suite) | ||
| # The harness runs all scenarios via unbounded Promise.all; with 40 | ||
| Expand Down | ||
| Back | FazBrowse Home | New Git URL |
Uh oh!
There was an error while loading. Please reload this page.