Repository navigation
feat(client): support HTTP auth in ClientSessionGroup - #3516
Open
musi22 wants to merge 6 commits into
Open
musi22 wants to merge 6 commits into
musi22 wants to merge 6 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/client/session-groups.md">
<violation number="1" location="docs/client/session-groups.md:83">
P2: Copying this example raises `NameError` for `client_metadata`, `token_storage`, `redirect_handler`, and `callback_handler`; define these values or link a complete runnable OAuth example.</violation>
<violation number="2" location="docs/client/session-groups.md:98">
P2: When the same auth object is assigned to two parameter instances, `ClientSessionGroup` shares its mutable OAuth context and tokens. Tell users to construct a distinct auth instance per server before claiming these lifecycles are independent.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Sorry, something went wrong.
Comment thread
docs/client/session-groups.md
Outdated
|
|
||
| server_auth = OAuthClientProvider( | ||
| server_url="https://api.example.com", | ||
| client_metadata=client_metadata, |
Copy link
Copy Markdown
There was a problem hiding this comment.
P2: Copying this example raises NameError for client_metadata, token_storage, redirect_handler, and callback_handler; define these values or link a complete runnable OAuth example.
Prompt for AI agentsCheck if this issue is valid — if so, understand the root cause and fix it. At docs/client/session-groups.md, line 83:
<comment>Copying this example raises `NameError` for `client_metadata`, `token_storage`, `redirect_handler`, and `callback_handler`; define these values or link a complete runnable OAuth example.</comment>
<file context>
@@ -70,6 +70,33 @@ If you already hold a connected `ClientSession` (`Client.session` is one), hand
+
+server_auth = OAuthClientProvider(
+ server_url="https://api.example.com",
+ client_metadata=client_metadata,
+ storage=token_storage,
+ redirect_handler=redirect_handler,
</file context>
Sorry, something went wrong.
Comment thread
docs/client/session-groups.md
| await group.connect_to_server(server_params) | ||
| ``` | ||
|
|
||
| Because `auth` is configured per `ServerParameters` instance, each server in the session group maintains independent authentication context, scopes, and token-refresh lifecycle. Custom headers can still be supplied alongside `auth` via `headers=`. |
Copy link
Copy Markdown
There was a problem hiding this comment.
P2: When the same auth object is assigned to two parameter instances, ClientSessionGroup shares its mutable OAuth context and tokens. Tell users to construct a distinct auth instance per server before claiming these lifecycles are independent.
Prompt for AI agentsCheck if this issue is valid — if so, understand the root cause and fix it. At docs/client/session-groups.md, line 98:
<comment>When the same auth object is assigned to two parameter instances, `ClientSessionGroup` shares its mutable OAuth context and tokens. Tell users to construct a distinct auth instance per server before claiming these lifecycles are independent.</comment>
<file context>
@@ -70,6 +70,33 @@ If you already hold a connected `ClientSession` (`Client.session` is one), hand
+ await group.connect_to_server(server_params)
+```
+
+Because `auth` is configured per `ServerParameters` instance, each server in the session group maintains independent authentication context, scopes, and token-refresh lifecycle. Custom headers can still be supplied alongside `auth` via `headers=`.
+
## Recap
</file context>
Suggested change
| Because `auth` is configured per `ServerParameters` instance, each server in the session group maintains independent authentication context, scopes, and token-refresh lifecycle. Custom headers can still be supplied alongside `auth` via `headers=`. | |
| Because `auth` is configured per `ServerParameters` instance, give each server a distinct auth instance to maintain independent authentication context, scopes, and token-refresh lifecycle. Custom headers can still be supplied alongside `auth` via `headers=`. |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Sorry, something went wrong.
Comment thread
docs/client/session-groups.md
added 4 commits
September 17, 2026 16:04
…anch misreporting
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1723
Summary
ClientSessionGroup server parameters (SseServerParameters and StreamableHttpParameters) lacked an auth field, requiring users to manually manage bearer tokens via the headers parameter and preventing automated OAuth flows (like OAuthClientProvider) with dynamic client registration and token refresh.
This change adds an optional auth: httpx2.Auth | None = None parameter to both HTTP server parameter models and propagates it into sse_client() and create_mcp_http_client().
Changes
Backward Compatibility
100% backward compatible:
Test Plan