StreamableHttp - stateless server support - #554
Conversation
Sorry, something went wrong.
jerome3o-anthropic
left a comment
There was a problem hiding this comment.
One question around initialization, also tests for this would be good.
Sorry, something went wrong.
| # When True, the server will wait for the client to send an initialization | ||
| # message before processing any other messages. | ||
| # False should be used for stateless servers. | ||
| require_initialization: bool = True, |
There was a problem hiding this comment.
[nit / question] should we just spoof the initialization on these requests with capabilities that a stateless server would have (i.e. capabilities={})? that way the life cycle of the mcp server is still spec compliant - it's a bit of a pointless dance though, so I'm happy to leave it as you have it.
The code as it stands feels like this could be interpreted as initialization being optional - that's my main concern
Sorry, something went wrong.
There was a problem hiding this comment.
I think I'd probaly change the name, require_initialization sounds like we are skipping the protocol requirement on intialization
Sorry, something went wrong.
|
Can we change the module name please, to something that is pep 8 compatible, like mcp.server.http.streamable |
Sorry, something went wrong.
jerome3o-anthropic
left a comment
There was a problem hiding this comment.
awesome!
Sorry, something went wrong.
The base branch was changed.
Tested with multi-client test script in Typescript introduced in this PR
uv run mcp-simple-streamablehttp-stateless --log-level DEBUG
uv run mcp-simple-streamablehttp-stateless --json-response
Follow ups
Stacked on top of #553