Repository navigation
Fix handle sse disconnect event to free read_stream_writers[session_id] - #582
Closed
lcamhoa wants to merge 9 commits into
Closed
lcamhoa wants to merge 9 commits into
lcamhoa wants to merge 9 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This looks better. Can you add a test case, please? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
I added . Please check |
Sorry, something went wrong.
ihrpr
reviewed
Apr 29, 2025
Comment thread
src/mcp/server/sse.py
| } | ||
| ) | ||
|
|
||
| async def handle_see_disconnect(message: Message) -> None: |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
this is also handled in #586. let's review that one first and then we can review this one as we have a test here -- thank you for adding it
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
I left my thought here And I don't think add callback to connect_sse is proper
Sorry, something went wrong.
ihrpr
requested changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When SSE Connection disconnect , we should free the _read_stream_writers
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context