Fix Windows subprocess NotImplementedError (STDIO clients) - #596

Merged

felixweinberger merged 14 commits into

modelcontextprotocol:mainfrom

theailanguage:fix/windows_stdio_subprocess

Jun 24, 2025

Commits on Jun 24, 2025

Fix Windows subprocess compatibility for STDIO mode with async streams
theailanguage
committed
9f5eecd
Fix: Windows stdio subprocess compatibility with type hints and fallback to subprocess.Popen
theailanguage
committed
306b28d
style(win32): fix import sorting and formatting issues
theailanguage
committed
2f26efd
style(stdio): format imports and wrap long lines for ruff compliance
theailanguage
committed
5b98439
updated tests - ignored test_stdio_context_manager_exiting, test_stdio_client on windows due to tee command issues
theailanguage
committed
02b3d3c
Revert "updated tests - ignored test_stdio_context_manager_exiting, test_stdio_client on windows due to tee command issues"
theailanguage
committed
a550b02
fix: rebase on main and resolve merge conflicts in stdio subprocess logic
theailanguage
committed
5815e6c
Fix Windows compatibility for STDIO with async DummyProcess
theailanguage
committed
dddff2b
added 6a703a4 closing file handles in __aexit__ in DummyProcess - Fix ResourceWarning by properly closing file handles in DummyProcess
theailanguage
committed
9e38ab5
pre_commit run issues fixed
theailanguage
committed
249d81e
Removed -c to simulate a real file not found error instead of executing a bad inline script. This ensures the subprocess fails to launch, which better matches the test's intent.
theailanguage
committed
d5e46c6
On Linux, terminating a process that has already exited raises ProcessLookupError. This can happen if the command failed to launch properly (as in this test case).
theailanguage
committed
0629a3f
Revert README, stdio/__init__.py, and test_stdio.py to match upstream main
theailanguage
committed
c8eaeba
emtpy commit to retrigger checks
theailanguage
committed
d9863c3

Fix Windows subprocess NotImplementedError (STDIO clients) by theailanguage · Pull Request #596 · modelcontextprotocol/python-sdk · GitHub

Uh oh!

Fix Windows subprocess NotImplementedError (STDIO clients) - #596

Fix Windows subprocess NotImplementedError (STDIO clients)#596
felixweinberger merged 14 commits into
modelcontextprotocol:mainfrom
theailanguage:fix/windows_stdio_subprocess

Commits on Jun 24, 2025

Fix Windows subprocess compatibility for STDIO mode with async streams

Fix: Windows stdio subprocess compatibility with type hints and fallback to subprocess.Popen

style(win32): fix import sorting and formatting issues

style(stdio): format imports and wrap long lines for ruff compliance

updated tests - ignored test_stdio_context_manager_exiting, test_stdio_client on windows due to tee command issues

Revert "updated tests - ignored test_stdio_context_manager_exiting, test_stdio_client on windows due to tee command issues"

fix: rebase on main and resolve merge conflicts in stdio subprocess logic

Fix Windows compatibility for STDIO with async DummyProcess

added 6a703a4 closing file handles in aexit in DummyProcess - Fix ResourceWarning by properly closing file handles in DummyProcess

pre_commit run issues fixed

Removed -c to simulate a real file not found error instead of executing a bad inline script. This ensures the subprocess fails to launch, which better matches the test's intent.

On Linux, terminating a process that has already exited raises ProcessLookupError. This can happen if the command failed to launch properly (as in this test case).

Revert README, stdio/init.py, and test_stdio.py to match upstream main

emtpy commit to retrigger checks

Fix Windows subprocess NotImplementedError (STDIO clients) by theailanguage · Pull Request #596 · modelcontextprotocol/python-sdk · GitHub

Uh oh!

Fix Windows subprocess NotImplementedError (STDIO clients) - #596

Fix Windows subprocess NotImplementedError (STDIO clients)#596felixweinberger merged 14 commits intomodelcontextprotocol:mainmodelcontextprotocol/python-sdk:mainfrom theailanguage:fix/windows_stdio_subprocesstheailanguage/python-sdk:fix/windows_stdio_subprocessCopy head branch name to clipboard

Commits

Commits on Jun 24, 2025

Fix Windows subprocess NotImplementedError (STDIO clients)#596
felixweinberger merged 14 commits into
modelcontextprotocol:mainfrom
theailanguage:fix/windows_stdio_subprocess