FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update CI configuration to support multiple OS environments by DanielAvdar · Pull Request #708 · modelcontextprotocol/python-sdk · GitHub

/ python-sdk Public

Update CI configuration to support multiple OS environments - #708

Merged
ihrpr merged 12 commits into
modelcontextprotocol:mainfrom
DanielAvdar:win-tests
May 14, 2025
ConversationCommits (12)ChecksFiles changed
Merged

Update CI configuration to support multiple OS environments#708
ihrpr merged 12 commits into
modelcontextprotocol:mainfrom
DanielAvdar:win-tests

Conversation

DanielAvdar commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

add windows tests for ci, required for preventing and solving issues related to windows.

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Update CI configuration to support multiple OS environments
5ec2a11 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Merge branch 'main' into win-tests
e07302d
Update test assertions to use Path for file paths
d432257 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Merge remote-tracking branch 'origin/win-tests' into win-tests
f6cdbf6
Fix path assertions in example tests for cross-platform compatibility
2906760 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Fix platform check for file path handling in test_examples.py
e6ecacc 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
DanielAvdar marked this pull request as ready for review May 13, 2025 18:30

DanielAvdar commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

We need to reference issues related to Windows testing for better context. Relevant examples include:

#671: MCP Tool execution hangs indefinitely in stdio mode when calling external Python scripts
#575: RuntimeError during cleanup on Windows – no running event loop
#391: Proactor Windows warning on cleanup when using stdio_client
#526: MCP Server with Python on Claude Desktop Never Exits
#391: Proactor Windows warning on cleanup when using stdio_client
#433: SSE Connection Failure Described as "throw new Error('Not connected')"
#662: Error when calling MCP tool with arguments and tool name in live environment
#668: Will not work if multiple MCP inspector windows are open
Additionally, a review from the maintainers is needed. The required PR checks are targeting outdated test names (specific to Linux). Maintainers should update the required checks to reflect the new configuration.

@ihrpr

ihrpr added this to the HPR milestone May 13, 2025
ihrpr previously approved these changes May 14, 2025
View reviewed changes

ihrpr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thank you!

I'll make changes in the config

Please can you rebase and I'll merge

Comment thread tests/test_examples.py
Update CI configuration to support multiple OS environments
e1116ce 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Update test assertions to use Path for file paths
fd5545e 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Fix path assertions in example tests for cross-platform compatibility
2fedc42 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Fix platform check for file path handling in test_examples.py
2f37315 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Merge remote-tracking branch 'origin/win-tests' into win-tests
ffb0d4d
Update CI configuration to allow continuation on error
888093d 
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
DanielAvdar requested a review from ihrpr May 14, 2025 12:13
ihrpr approved these changes May 14, 2025
View reviewed changes

ihrpr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thank you

ihrpr merged commit b8f7b02 into modelcontextprotocol:main May 14, 2025
maxisbey mentioned this pull request Jul 9, 2026
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ihrpr ihrpr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

HPR

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL